Back to Questions
4.0k
views2
comments
Why does the function flow incorrectly in this code
f#ocaml

I've just started getting into F# which I have enjoyed immensely because of its clean syntax and pragmatic functionalism. I've translated some ocaml code which I had written previously to see how much more concise it could be with the .Net libs and the #light syntax. The result is the code below which works, but the printing of directories occurs all at once followed by the process calls occurring all at once instead of in sequence as the code should intuitively provide fo:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36

#light

open System
open System.IO
open System.Diagnostics

let ops = [
    (".bzr", ["bzr pull"; "bzr update"])
    (".hg",  ["hg pull"; "hg update"])
    (".svn", ["svn update"])
    (".git", ["git pull"])] |> Map.ofList

let srcdir = "/home/sa/src"

let run (cmd : string) =
    let args = cmd.Split()
    let x, y = args.[0], args.[1]
    Process.Start(x, y)

let get_dirs path = Array.toList(Directory.GetDirectories(path))

let update path = 
    let projects = get_dirs path
    for proj in projects do
        let dirs = get_dirs proj
        for dir in dirs do
            let dirname = Path.GetFileName(dir)
            if ops.ContainsKey(dirname) then
                printfn "\nproj: %A" proj
                Directory.SetCurrentDirectory(proj)
                for cmd in ops.Item(dirname) do
                    run cmd |> ignore

let main() = update srcdir

main()

The run provides the following output:

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18

sa@srv:~/workspace/update$ ./update.exe 
proj: "/home/sa/src/berp"
proj: "/home/sa/src/boo"
proj: "/home/sa/src/bottle"
proj: "/home/sa/src/io"
proj: "/home/sa/src/leo-editor"
proj: "/home/sa/src/libscript"
proj: "/home/sa/src/pure-lang"
proj: "/home/sa/src/pymeta"
sa@srv:~/workspace/update$ Already up-to-date.
Already up-to-date.
Already up-to-date.
Already up-to-date.
Already up-to-date.
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
pulling from https://pure-lang.googlecode.com/hg/
searching for changes
no changes found

I would appreciate some feedback on why this is occurring.

Many thanks in advance.

AK

.

Don't you wanna wait for command in run to complete? E.g. Process.Start(x, y).WaitForExit()

By on 1/11/2011 6:10 AM ()

You are absolutely spot on with your analysis of the problem and the solutions. Works as expected now.

Thank you!

AK

By on 1/11/2011 6:25 AM ()

    Topic tags

    IntelliFactory Offices Copyright (c) 2011-2012 IntelliFactory. All rights reserved.
    Home | Products | Consulting | Trainings | Blogs | Jobs | Contact Us | Terms of Use | Privacy Policy | Cookie Policy     		Built with WebSharper